# Review TypeScript Changes Against Metabase Standards

TypeScript reviews can miss project rules, accessibility issues, and performance regressions. This skill applies Metabase standards and prioritizes actionable findings.

## Install

```bash
npx skillstore add metabase/typescript-review
```

## Metadata

- Status: approved
- Slug: metabase-typescript-review
- Skillstore revision: r2
- Version status: missing
- Tree hash: e4de343a2ac51beafc98d64bd9bda7e2bf61b213f20b264f6a1a596bc8b31c29
- Author: metabase
- GitHub username: metabase
- License: MIT
- Repository: https://github.com/metabase/metabase/tree/master/.claude/skills/typescript-review
- Ref: ebdfe608f5de2b66ff37ab4af12af8ac4f5e8006
- Supported tools: Claude, Codex, Claude Code
- Audit status: complete
- Agent install advisory: allowed
- Manual install advisory: allowed
- Artifact signature: available
- Audit attestation: unavailable
- Human verification: not\_verified
- Risk factors: external\_commands, filesystem
- Quality score: 79
- Quality tier: bronze
- Public page: https://skillstore.pages.dev/skills/metabase-typescript-review
- Manifest: https://skillstore.pages.dev/api/skills/metabase-typescript-review/manifest

## Capabilities

- Reviews TypeScript and JavaScript pull request diffs against Metabase coding standards.
- Prioritizes linked typescript-write rules, including prohibited explicit or implicit any usage.
- Checks type modeling, null handling, naming, structure, comments, and maintainability.
- Flags testing, accessibility, performance, security, bundle size, and analytics concerns.
- Uses language server evidence when verifying prohibited any types.

## Use Cases

- Review a frontend pull request: Check a TypeScript diff for blocking standards violations and secondary quality concerns before requesting review.
- Prioritize review findings: Sort code review feedback by project rules, maintainability, testing, accessibility, performance, security, and product instrumentation.
- Audit team review coverage: Identify recurring blind spots across frontend changes, including bundle impact, analytics events, and keyboard accessibility.

## Prompt Templates

### Basic diff review

```
Review this TypeScript diff. List blocking issues first, then testing, accessibility, performance, security, bundle size, and analytics concerns.
```

### Standards compliance review

```
Review these JavaScript and TypeScript changes against Metabase standards. Cite affected files and explain each recommended change.
```

### Frontend risk review

```
Analyze this frontend pull request for type safety, test gaps, accessibility, performance, security, bundle growth, and missing analytics events.
```

### Advanced prioritized review

```
Review the complete diff and rank findings by severity. Separate blocking standards violations from additive concerns and note uncertain conclusions.
```

## Limitations

- Depends on repository guidance files that are not included in this skill package.
- Does not replace automated tests, type checking, linting, or dedicated security analysis.
- Provides review findings but does not modify code or create fixes automatically.
- Metabase-specific rules may not suit unrelated TypeScript projects.

## Best Practices

- Provide the complete diff and relevant repository context for accurate findings.
- Run type checks, tests, and linting before using the skill for final review.
- Validate blocking findings against the linked Metabase guidance and language server output.

## Anti Patterns

- Do not use the skill as the only security or accessibility review.
- Do not apply Metabase-specific rules to unrelated repositories without adapting the standards.
- Do not treat every suggestion as blocking when the skill marks concerns as additive.

## Security Audit

- Audited at: 2026-07-23T17:32:19.155\+00:00
- Summary: All ten static findings are false positives. Six detections misread Markdown inline-code backticks as shell execution, and four flag fixed documentation references as path traversal.

## Stats

- Views: 192
- Downloads: 14
- Favorites: 0
- Popularity score: 0