# Review Code Against Standards and Specs

Code reviews can miss whether changes follow project rules and match the requested work. This skill separates standards review from specification review so each concern is visible.

## Install

```bash
npx skillstore add mattpocock/code-review
```

## Metadata

- Status: approved
- Slug: mattpocock-code-review
- Skillstore revision: r1
- Version status: missing
- Tree hash: da5772bc26f39fc39db0d63966b91c131b06851ddc52802dc7e1bebdfa260c15
- Author: mattpocock
- GitHub username: mattpocock
- License: MIT
- Repository: https://github.com/mattpocock/skills/tree/main/skills/engineering/code-review/
- Ref: 1ffa7643651792ccb4bd3b15d924d2c97edff755
- Supported tools: Claude, Codex, Claude Code
- Audit status: complete
- Agent install advisory: allowed
- Manual install advisory: allowed
- Artifact signature: available
- Audit attestation: unavailable
- Human verification: not\_verified
- Risk factors: external\_commands
- Quality score: 77
- Quality tier: bronze
- Public page: https://skillstore.pages.dev/skills/mattpocock-code-review
- Manifest: https://skillstore.pages.dev/api/skills/mattpocock-code-review/manifest

## Capabilities

- Compares HEAD with a user supplied fixed point using a three-dot git diff.
- Checks changed code against documented repository standards and a built-in code-smell baseline.
- Checks implementation changes against an originating issue, PRD, or specification when available.
- Runs standards and spec review as separate sub-agent passes to keep findings independent.
- Reports Standards and Spec findings in separate sections with counts and worst issue per axis.

## Use Cases

- Review a feature branch before opening a pull request: Compare the branch against main and identify standards issues or missing specification requirements.
- Check implementation against a product requirement: Use an issue, PRD, or spec file to confirm the diff matches the requested behavior.
- Separate style concerns from scope concerns: Keep coding-standard feedback separate from spec-compliance feedback during review.

## Prompt Templates

### Basic branch review

```
Review this branch since main.
```

### Review since a specific commit

```
Review the changes since commit abc123 against our standards and the spec.
```

### Review with a spec file

```
Review since main using docs/specs/checkout-flow.md as the spec source.
```

### Review a work-in-progress branch

```
Review since origin/main. Keep Standards and Spec findings separate, and note if any spec requirement is missing.
```

## Limitations

- Requires a valid fixed point such as a branch, tag, or commit SHA.
- Spec review is skipped or limited when no issue, PRD, or specification is available.
- Findings depend on accessible repository standards and issue-tracker context.
- It reviews diffs and documentation; it does not replace tests or runtime verification.

## Best Practices

- Provide a clear fixed point, such as main, origin/main, or a commit SHA.
- Point to the issue, PRD, or spec file when the branch name does not reveal it.
- Run normal tests and type checks separately after using this review.

## Anti Patterns

- Do not use it without a fixed point unless you are ready to clarify the comparison target.
- Do not treat code-smell findings as hard failures without human judgement.
- Do not use the spec review as a substitute for product acceptance testing.

## Security Audit

- Audited at: 2026-07-09T04:09:27.828\+00:00
- Summary: The static findings are false positives caused by Markdown inline code and ordinary git review instructions. No prompt injection, data exfiltration, malware behavior, or unrelated destructive intent was found in SKILL.md.

## Stats

- Views: 0
- Downloads: 5
- Favorites: 0
- Popularity score: 0